Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Hide sign-up link when DISABLE_SIGNUPS: true #2164

Open
1 task done
surfingbytes opened this issue Jan 20, 2025 · 0 comments
Open
1 task done

[Feature] Hide sign-up link when DISABLE_SIGNUPS: true #2164

surfingbytes opened this issue Jan 20, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version

Comments

@surfingbytes
Copy link

Is there an existing issue for this feature?

  • Yes, I have searched the existing issues and it doesn't exist.

Feature Description

Currently, when you set DISABLE_SIGNUPS: true, the "Don't have an account? Create one now" is still shown. Error message about it being disabled is shown only after user clicks the link. That is generally bad practice, why is user allowed to click on that link at all? Why is that even shown when user can't use it? I can't imagine any other software showing buttons that you don't have right to click on - e-mail client showing "delete" on e-mails, when you don't have rights in this mailbox, bank showing "send transfer" when you have read-only access to that account. And only after you click on it you get "oh, you actually can't"

Same situation when you set DISABLE_EMAIL_AUTH: true. Check any other software - the login form just disappears and it automatically redirects to configured OPENID provider. Currently, the whole form stays there, blurred, with a message on top. So if you disable e-mail login to make it smoother, you end up with this mess:

Image

@surfingbytes surfingbytes added enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version
Projects
None yet
Development

No branches or pull requests

2 participants