Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some light request fields are actually optional #16

Open
jiri-janousek opened this issue Sep 5, 2019 · 1 comment
Open

Some light request fields are actually optional #16

jiri-janousek opened this issue Sep 5, 2019 · 1 comment
Labels
bug Something isn't working eidas-bug Bug in eIDAS Node or its documentation.

Comments

@jiri-janousek
Copy link
Contributor

These fields shouldn't be optional according to XML schema (eIDAS-Node National IdP and SP Integration Guide, Version 2.3, page 47):

  • <xs:element name="subject" type="xs:string" minOccurs="1" maxOccurs="1" />
  • <xs:element name="subjectNameIdFormat" minOccurs="1" maxOccurs="1" />
  • <xs:element name="levelOfAssurance" minOccurs="1" maxOccurs="1" />

However, they are optional for failed responses: eIDAS node accepts and provides light responses without these fields.

Changes to implement:

  • LightResponse.validate() - treat subject, subject_name_id_format, and level_of_assurance as optional if status.failure is True.
  • SAMLResponse.create_light_response() - stop providing dummy data for subject, subject_name_id_format, and level_of_assurance in case of failure responses.
@jiri-janousek jiri-janousek added bug Something isn't working critical Should be resolved as soon as possible. labels Sep 5, 2019
@jiri-janousek jiri-janousek self-assigned this Sep 5, 2019
@jiri-janousek jiri-janousek added the eidas-bug Bug in eIDAS Node or its documentation. label Sep 5, 2019
jiri-janousek pushed a commit that referenced this issue Sep 5, 2019
Make some LightResponse fields optional
065031e 
Ref #16
jiri-janousek pushed a commit that referenced this issue Sep 5, 2019
Make some LightResponse fields optional
4914446 
Ref #16
@jiri-janousek jiri-janousek mentioned this issue Sep 5, 2019
Merged
jiri-janousek pushed a commit that referenced this issue Sep 6, 2019
Make some LightResponse fields optional
7358e1e 
Ref #16
tpazderka pushed a commit that referenced this issue Sep 10, 2019
@tpazderka
Make some LightResponse fields optional
cbce40a 
Ref #16
@jiri-janousek jiri-janousek removed the critical Should be resolved as soon as possible. label Oct 11, 2019
@jtalir
Copy link
Collaborator

jtalir commented Jan 20, 2021

Should be fixed in CEF eIDAS Node 2.5

@jiri-janousek jiri-janousek removed their assignment May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working eidas-bug Bug in eIDAS Node or its documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtalir @jiri-janousek