Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued support for this repo #58

Open
mwhamgenomics opened this issue Mar 30, 2022 · 4 comments
Open

Continued support for this repo #58

mwhamgenomics opened this issue Mar 30, 2022 · 4 comments

Comments

@mwhamgenomics
Copy link
Collaborator

I can make sure the tests pass, but I don't have access to an instance of Clarity anymore, so don't have any way of validating new versions IRL. Also not sure if it's still in use at Edinburgh Genomics.

@tbooth - it may be good to review this fork versus the upstream and have a think about what should be done with it

@tbooth
Copy link
Member

tbooth commented Mar 30, 2022

Hi @mwhamgenomics we are still using the library for some small, specific things, but the code is fossilised so I've not thought about maintaining this repo. I guess for most people they would hope to get a working version with 'pip install ...', so if others are maintaining a better fork then maybe the best thing is to hand them control of the package in PIP. I'm not sure what this involves.

I could test fixes against our Clarity, possibly, but I think bugs are most likely to show against newer Clarity versions and we don't have those, so any prospective maintainer needs to be someone who is running a Clarity server and actually upgrading it.

@mmatthews06
Copy link

mmatthews06 commented Oct 17, 2022

@tbooth and @mwhamgenomics , is this roughly equivalent to the Semaphore library?
https://github.com/SemaphoreSolutions/s4-clarity-lib

Do you have a list of differences, or are the differences relatively trivial? Was this library created before that one was largely available, or anything like that?

@mwhamgenomics
Copy link
Collaborator Author

Hi @mmatthews06,

I don't know much about that repo. Its first commit is from 2019 though, so it wouldn't have been around at the time we forked this repo. It seems to do a lot of the same things, but does them in different ways behind the scenes and the code's structured slightly differently - so I don't have a list of differences, but the way it's used should have some similarities.

@mmatthews06
Copy link

Thank you! That's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants