-
Notifications
You must be signed in to change notification settings - Fork 52
New configuration for Guava Range default bound type. #79
Conversation
@cowtowncoder What about that failing test?
|
@jorool I do not see any test failures. Message would indicate that you haven't done a clean Maven build perhaps? ("mvn clean compile") |
@cowtowncoder I'm talking about Travis CI. The "check" failed. 😄 |
Hmmh. That's odd, but reliability of Travis setup has been rather poor. :-( |
@cowtowncoder So... what should we do? Will you merge it? |
Yes, I think that's good enough. One thing first however: unless I have asked about it already... we need filled in Contributor License Agreement (https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf) before the first merger contribution. This is only needed once, and after that we can accept any number of contributions for Jackson projects. The easiest way is usually to print CLA form, fill & sign, scan and email to Thank you in advance. |
@cowtowncoder Done. Email sent. Let me know if you need something else. Thanks. |
New configuration for Guava Range default bound type.
@@ -3,7 +3,11 @@ | |||
import com.fasterxml.jackson.core.Version; | |||
|
|||
import com.fasterxml.jackson.databind.*; | |||
import com.fasterxml.jackson.databind.cfg.PackageVersion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this caused the bug -- PackageVersion must not come from version of another module, like jackson-databind
.
It is generated by Maven build. I removed this which fixes the unit test fail.
Now it's possible do set a default bound type for Guava Range objects.
The intent of this is to get the JSON deserialized without informing the bound types every time even when wanted to use the same one for all objects.
The configured default bound type is passed to the deserializer by constructor method.
If the JSON object has no bound type and there's no default configured, we still get the exception.
I added some test cases with and without default bound type configured.