Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Incompatibility of plugin Flow.Launcher.Plugin.Explorer with Everything (1.5a) #1769

Closed
1 task done
oSumAtrIX opened this issue Jan 9, 2023 · 2 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@oSumAtrIX
Copy link
Contributor

oSumAtrIX commented Jan 9, 2023

Checks

  • I have checked that this issue has not already been reported.

Problem Description

If Everything 1.5a is used and properly installed as a service instead of Everything 1.4, the current latest version, IsEverythingRunningAsync will return false:

public static async ValueTask<bool> IsEverythingRunningAsync(CancellationToken token = default)
{
await _semaphore.WaitAsync(token);
try
{
EverythingApiDllImport.Everything_GetMajorVersion();
var result = EverythingApiDllImport.Everything_GetLastError() != StateCode.IPCError;
return result;
}
finally
{
_semaphore.Release();
}
}

More context on this might be revealed through the comment here:

public string SortOptionWarningMessage
{
get
{
try
{
// this method is used to determine if Everything service is running because as at Everything v1.4.1
// the sdk does not provide a dedicated interface to determine if it is running.
return EverythingApi.IsFastSortOption(Settings.SortOption) ? string.Empty
: Context.API.GetTranslation("flowlauncher_plugin_everything_nonfastsort_warning");
}
catch (IPCErrorException)
{
return Context.API.GetTranslation("flowlauncher_plugin_everything_is_not_running");
}
catch (DllNotFoundException)
{
return Context.API.GetTranslation("flowlauncher_plugin_everything_sdk_issue");
}
}
}

To Reproduce

  1. Install Flow Launcher and Everything 1.4, and observe that the Flow Launcher Explorer plugin works
  2. Install Everything 1.5a (It is stated, that it seamlessly migrates from 1.4 to 1.5a which it does indeed), and observe the Flow Launcher Explorer plugin does not work

Screenshots

image

image

image

Flow Launcher Version

v1.11.0

Windows Build Number

10.0.22621.963

@oSumAtrIX oSumAtrIX added the bug Something isn't working label Jan 9, 2023
@VictoriousRaptor
Copy link
Contributor

Dup #1716. Please try the fix in the comment. This is a known issue, and it's because Everything SDK is uncompatible with its alpha version.

@oSumAtrIX
Copy link
Contributor Author

Following up on your suggestion, #1716 (comment) worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants