Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with xcopy command #205

Open
daooze opened this issue Jan 13, 2025 · 3 comments
Open

Issue with xcopy command #205

daooze opened this issue Jan 13, 2025 · 3 comments
Assignees

Comments

@daooze
Copy link

daooze commented Jan 13, 2025

Hi there.

I have used MDT for plenty of years but I´m new to PSD. Currently testing Windows 11 deployment with PSD version 0.2.3.0. As I wanted to have a similar deployment environment as with MDT, I have set up a fileserver to deploy over SMB. HTTP(S) I will be testing later on.

During my first steps with PSD I stumbled upon an issue when it comes to copying the OS WIM from my fileshare to the local cache folder. This is done using xcopy, defined in PSDUtility.psm1 on line 528. The parameters for the source and destination paths need to be enclosed into double quotes, as at least the source path has a whitespace in it.

The original line reads
$null = Start-Process xcopy -ArgumentList "$s $d /s /e /v /d /y /i" -NoNewWindow -Wait -Passthru -RedirectStandardOutput xcopy

The modified line should read
$null = Start-Process xcopy -ArgumentList """$s"" ""$d"" /s /e /v /d /y /i" -NoNewWindow -Wait -Passthru -RedirectStandardOutput xcopy

Maybe you can fix that in the repo.

Regards.

@GeoSimos
Copy link
Collaborator

Hello @daooze,

Unfortunately the SMB method is not supported or endorsed for the PSD solution. You will find this in the documentation section.
Although some fellows have been able to change the code and switch to SMB instead of HTTPS, that's not what the solution is designed and intended to be used for.
If you search in the issues, you will see similar reports, but the answer is the same as in your case.

@GeoSimos GeoSimos self-assigned this Jan 13, 2025
@daooze
Copy link
Author

daooze commented Jan 14, 2025

Hi @GeoSimos ,

thanks for the clarification. I did read the documentaion but did not find anything that says "SMB is not supported"; or maybe I did'nt get it. The scripts include UNC path stuff so I thought it is still an option to use it like with MDT.

I'll go for HTTP then...

@PowerShellCrack
Copy link
Contributor

PowerShellCrack commented Jan 19, 2025

In my opinion, the term "unsupported" should be replaced with "deprecated" or "no longer actively developed." While this is a community-driven project rather than a commercial product, it's worth clarifying that we’ve shifted focus to more effective solutions. For SMB, while code still exists within the modules, active development has ceased. We’ve prioritized HTTP(S) as it offers a more modern and robust solution, better aligning with the project's evolution.

With that, no matter what you plan on using, I do see a potential "bug" with the xcopy code. If there are spaces in the paths, it should be incapsulated in quotes as you mentioned. This may be something we need to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants