Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default auto refresh config #21351

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add default auto refresh config #21351

wants to merge 5 commits into from

Conversation

maxiadlovskii
Copy link
Contributor

Description

This PR adds the option to add default auto-refresh config to AutoRefreshProvider
We are changing the default config for Events. Now it's starts automatically with 30s interval

Motivation and Context

fix: #21350

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

dennisoelkers
dennisoelkers reviewed Jan 22, 2025
View reviewed changes
graylog2-web-interface/src/components/events/events/EventsRefreshControls.tsx Outdated
import type { RefreshConfig } from 'views/components/contexts/AutoRefreshContext';
import { durationToMS } from 'util/DateTime';

const defaultInterval = 'PT30S';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we should hardcode it. What are arguments against reusing the search refresh defaults for this? 5s does not seem to be too low for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisoelkers 30 sec that was a product requirement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify if it was even considered to reuse the configurable values or if that number was just an educated guess, without knowing that a user can configure it in other places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this question. Let's wait for a response

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisoelkers After discussions we decided to use the default interval from configuration. Pushed the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linuspahl linuspahl Awaiting requested review from linuspahl

@dennisoelkers dennisoelkers Awaiting requested review from dennisoelkers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start autorefresh automatically with interval 30s on Events page
2 participants
@maxiadlovskii @dennisoelkers