Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New configuration to (dis-)allow external users create access tokens #21438

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fpetersen-gl
Copy link
Contributor

@fpetersen-gl fpetersen-gl commented Jan 24, 2025

Fixes #21403

Add a new configuration-entry to manage creation of access-tokens for external users.

Description

The configuration's value is considered when a user wants to create a new access token. For internal users, it doesn't make a difference, for external ones, it would forbid creating a token if set to false. Otherwise, external users are also allowed to create access tokens.

Starting with graylog 6.2, the configuration is set to not allow external users creating an access token. Before that version, it is allowed, to prevent a breaking change.

Motivation and Context

How Has This Been Tested?

There are test-cases covering all three options (internal user, external with setting being true and external user with setting being false).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

…access token (or not). Starting with graylog 6.2, this is set to not allow.
@fpetersen-gl fpetersen-gl marked this pull request as ready for review January 24, 2025 13:18
@fpetersen-gl fpetersen-gl requested a review from a team January 24, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend work for config setting "Allow access tokens for external users"
1 participant