Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Ensure docstring documentation exists in major sub-modules of gempyor #462

Open
emprzy opened this issue Jan 10, 2025 · 4 comments · May be fixed by #468
Open

[Feature request]: Ensure docstring documentation exists in major sub-modules of gempyor #462

emprzy opened this issue Jan 10, 2025 · 4 comments · May be fixed by #468
Assignees
Labels
documentation Relating to ReadMEs / gitbook / vignettes / etc. gempyor Concerns the Python core. high priority High priority. quick issue Short or easy fix.

Comments

@emprzy
Copy link
Collaborator

emprzy commented Jan 10, 2025

Label

documentation, gempyor

Priority Label

high priority

Is your feature request related to a problem? Please describe.

In order to generate Sphinx documentation for gempyor, there should be fully fleshed-out docstring documentation at least at the module level in gempyor, ideally for all classes and major functions. Completion of this issue should precede work on GH #458.

Is your feature request related to a new application, scenario round, pathogen? Please describe.

N/A

Describe the solution you'd like

I will comb the sub-modules in gempyor and fill-in missing docstring documentation. Then I will execute on GH #458.

@emprzy emprzy added documentation Relating to ReadMEs / gitbook / vignettes / etc. gempyor Concerns the Python core. high priority High priority. labels Jan 10, 2025
@emprzy emprzy self-assigned this Jan 10, 2025
@TimothyWillard TimothyWillard added this to the Software Quality milestone Jan 13, 2025
@emprzy
Copy link
Collaborator Author

emprzy commented Jan 13, 2025

  • compartments.py
  • inference.py
  • model_info.py
  • parameters.py
  • utils.py (specifically read_df and write_df

@pearsonca
Copy link
Contributor

Runnings notes:

  • Did not add module-level documentation to cli.py, as there isn't much to document. Could go back and add later for consistency's sake?

cli.py is the pipeline, flepimop, not gempyor (conceptually; obviously everything as currently organized is gempyor).

@emprzy
Copy link
Collaborator Author

emprzy commented Jan 13, 2025

Runnings notes:

  • Did not add module-level documentation to cli.py, as there isn't much to document. Could go back and add later for consistency's sake?

cli.py is the pipeline, flepimop, not gempyor (conceptually; obviously everything as currently organized is gempyor).

I see. So do you have a directive related to inline documentation wrt this or were you just letting me know?

@pearsonca
Copy link
Contributor

Yeah, let's prioritize documentation of gempyor-the-model and gempyor-the-inference tool. for now, gempyor-the-pipeline-aka-flepimop doesn't need docstring - so cli, shared_cli, probably config validator, testing, ...utils? ...profile? ...file_paths? Those are probably down the priority tree.

@emprzy emprzy linked a pull request Jan 15, 2025 that will close this issue
@TimothyWillard TimothyWillard added the quick issue Short or easy fix. label Jan 16, 2025
@TimothyWillard TimothyWillard linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relating to ReadMEs / gitbook / vignettes / etc. gempyor Concerns the Python core. high priority High priority. quick issue Short or easy fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants