Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour step flow tracking #26

Open
IGreatlyDislikeJavascript opened this issue Aug 29, 2019 · 0 comments
Open

Tour step flow tracking #26

IGreatlyDislikeJavascript opened this issue Aug 29, 2019 · 0 comments
Labels
enhancement New feature or request low priority

Comments

@IGreatlyDislikeJavascript
Copy link
Owner

Legacy issue from original Tour.

Currently, no proper tracking of tour steps is performed. This means use of Prev/Next is just a simple numerical jump backwards and forwards, instead of a true move to the previous (and next) tour steps.

This is a slight edge case. In most use cases this doesn't manifest as a problem, however if a tour uses non-trivial logic in callbacks (onNext, onShow etc) along with tour.goTo to maniplate the flow of a tour during "tour time", the Prev/Next buttons may not operate in a way the user - or the tour implementor - is expecting.

The solution is to properly implement tour step tracking by pushing the step index to a tracking array on each tour.showStep(), and popping on each tour.prev() call.

However further funcs need to be exposed to allow calling code to manipulate the tour step tracking array, so that step flow after use of tour.goTo() and similar can be managed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

1 participant