Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HexGloop text rendering incompatability #90

Open
SamsTheNerd opened this issue Dec 9, 2023 · 0 comments
Open

HexGloop text rendering incompatability #90

SamsTheNerd opened this issue Dec 9, 2023 · 0 comments

Comments

@SamsTheNerd
Copy link

howdy ! I have a mod called HexGloop that changes the text rendering to be able to render Hex Casting's patterns and it seems to break when Emojiful is installed.

Gloop has a few main mixins:

  1. Style parsing and injecting https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinParsePatternFormatting.java & https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinPatternStyle.java
    As far as I can tell emojiful doesn't effect these? Could be wrong though

  2. TextRenderer$Drawer's accept (or for your mapping Font$StringRenderOutput's) handles most of the rendering https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinTextDrawerPatSty.java

  3. Injecting into TextRenderer/Fonts constructor to change the character widths to match https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinPatTextWiden.java

It looks like EmojiFontRenderer$EmojiCharacterRenderer.accept() just uses a copy paste of the code from Font$StringRenderOutput.accept() for everything in the first else block ? Having it just call the code directly would probably fix the issue with my accept mixin

I think all the other mixins should work fine ? but wanted to list them incase you see anything that'd break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant