Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP.jl's retry layer instead of Retry in http_request #39

Open
iamed2 opened this issue Jun 25, 2018 · 1 comment
Open

Use HTTP.jl's retry layer instead of Retry in http_request #39

iamed2 opened this issue Jun 25, 2018 · 1 comment

Comments

@iamed2
Copy link
Member

iamed2 commented Jun 25, 2018

The check there seems pretty similar to the RetryLayer in HTTP.jl, but the RetryLayer handles more of HTTP.jl's failure cases. This would require JuliaWeb/HTTP.jl#259 in order to handle the AWSCore-specific failure cases (e.g., ParseError).

@samoconnor
Copy link
Contributor

This seems sensible in principle.
Do you have a use case where it is causing a practical problem?

I don't think the ParseError case is actually ever used. I can' think of a real recoverable situation where HTTP would return a ParseError.
There is other detail to consider, like here where streaming responses are handled. Where as in HTTP.jl here they are simply treated as non-retryable.
Also AWSCore.jl retries requests which HTTP.jl would consider to be non-idempotent. We'd have to think about the impact of that a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants