Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate ComponentSerializer services #59

Open
zml2008 opened this issue Sep 6, 2021 · 1 comment
Open

Evaluate ComponentSerializer services #59

zml2008 opened this issue Sep 6, 2021 · 1 comment

Comments

@zml2008
Copy link
Member

zml2008 commented Sep 6, 2021

With 4.8.0, ComponentSerializer services are available to customize how serializers are initialized.

Classloading on Bukkit makes ServiceLoader a bit fragile, but would it be worth implementing these on the platforms?

There is the additional issue of this causing problems for users who shade without enabling the appropriate service file transformers -- the serializer services will silently fail to initialize, leading to more support requests.

@kezz
Copy link
Member

kezz commented Sep 6, 2021

I think providing a default would be a good solution as that is what most users will be expecting anyway. Or perhaps provide our own supplier but ignore it if possible when obtaining other instances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants