-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtendedDesktopSize support? #91
Comments
Hello, |
I've had to move on to other tasks, but would still like to get away from Xvnc someday. |
Thank you! I'm eager to test this out. |
@maxnet has funded $50.00 to this issue.
|
Added some pizza money for the reviewer ;-) |
I built x11vnc from your branch along with LibVNC/libvncserver, which already has your patch merged. And it almost works but not quite. |
Are that all messages you see in the log? In addition to the log lines you see that are generated by libvncserver, x11vnc itself should print some additional lines as well (starting with "Received SetDesktopSize message from client requesting (%dx%d) framebuffer with screen configuration:") If you do not see that, it is likely that x11vnc has not been compiled correctly with support for setdesktopsize hook. And when running x11vnc it does not spit out any error messages mentioning xrandr? (e.g. "Need at least RANDR 1.3 to support scaling, only %d.%d available") |
Based on config.log, it seemed to find RANDR and "_rfbScreenInfo.setDesktopSizeHook": |
You did start x11vnc with -setdesktopsize ? |
With -setdesktopsize, I'm closer still, but I get: |
Size must be in the ranges supported by your graphic driver.
Have not tested any dummy drivers. |
Suspecting that the dummy X driver may not be supporting randr at all. Currently it bails out directly in the code then:
Guess I should add a line that logs an error there. Perhaps the new Virtual KMS driver is a better option if you have a system without any GPU. |
Dummy is supposed to support RANDR and should be a reasonable choice for a headless system. |
Recall you need to start with -dbg to see the backtrace which could give a clue which command gives an error. |
With -dbg, I see the "Welcome to the x11vnc crash shell" message following "caught X11 error," but nothing else that points to a problem. |
I've now been successful testing on a host with a GPU and the proprietary Nvidia driver. I will need a solution for headless non-GPU systems too, but this is exciting! Thanks for all your work. |
Looks like I'd assumed too much about RANDR support in the X dummy driver. Per this message, it looks like dummy lacks XRRSetScreenSize. That post is a few years old, but nobody's done much with dummy since then either. I will change gears and look at Xvfb instead. |
Yep, I'll look at Virtual KMS too, thanks for that. |
The minimum kernel level for VKMS is 4.19, but my environment is currently based on CentOS 7 (kernel 3.10.0). I'll try to stand up something newer to test VKMS when I get some cycles. |
@coredump4 Your work is greatly appreciated, please continue on this! 🙏 |
Oh this seems to be the issue encountered, what blocks this? |
Lack of time due to 👶care intensified due to 👑. Will tackle this once the pandemic situtation has settled here. |
An app I use uses x11vnc as middleware, is there any update on this? :) |
AFAIK it would require x11vnc to create and add mode, something like this but through a programmatic interface (assuming that exists):
and it would probably be much harder (if possible at all) implement the support for the Xorg (as opposed to Xvfb) case. (EDIT: what's worse is that Xvfb screen size is bound by its initial dimension, meaning that you can't add a mode latter that is wider and/or taller than the size.) I haven't really checked how exactly Xvnc (i.e. TigerVNC) implemented it, but it might be worth mentioning that it uses its own X server implementation instead of Xvfb. (Well, AFAICT.) |
I have a workaround with a 10-line shell script that works with Openbox. |
Hi,
When using a noVNC v1.0.0 client with "remote resize" enabled, the user's desktop can be resized to fit the browser window if the server supports ExtendedDesktopSize encoding. For me, the resizing does not work for x11vnc v0.9.16, but does if I switch to Xvnc.
Does x11vnc support ExtendedDesktopSize? If it does, I could use some help figuring out why the client & server are not in agreement on their protocol extensions.
Also, see this issue.
Thanks.
IssueHunt Summary
Backers (Total: $50.00)
Become a backer now!
Or submit a pull request to get the deposits!
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: