Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add option to read hidden rows #185

Open
0xced opened this issue Sep 23, 2024 · 3 comments
Open

Feature request: add option to read hidden rows #185

0xced opened this issue Sep 23, 2024 · 3 comments

Comments

@0xced
Copy link
Contributor

0xced commented Sep 23, 2024

The ExcelDataReaderOptions already has the ReadHiddenWorksheets option. It would be nice to also have a ReadHiddenRows option. It should default to true in order not to break compatibility with existing code.
@MarkPflug
Copy link
Owner

Would probably make sense to also allow skipping hidden columns.

@0xced
Copy link
Contributor Author

0xced commented Sep 25, 2024

Absolutely! Should probably be ReadHiddenCells instead of ReadHiddenRows. Would you be interested in a pull request?

@MarkPflug
Copy link
Owner

No PR needed. I think I have it working for .xlsx, just need to add the other formats and add some test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xced @MarkPflug