Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV: RowNumber and line breaks inside fields #243

Open
shameleo opened this issue Feb 8, 2024 · 1 comment
Open

CSV: RowNumber and line breaks inside fields #243

shameleo opened this issue Feb 8, 2024 · 1 comment

Comments

@shameleo
Copy link

shameleo commented Feb 8, 2024

RFC4180 allows line break inside quoted field, and Sylvan.Data.Csv handles this just fine, but CsvDataReader.RowNumber counts records, not actually read lines of file. Could you add one more property for actually read lines? Its important in case of some validation error, when we need to reference to the file line. I guess it shouldn't affect performance in any noticable way?

@MarkPflug
Copy link
Owner

This sounds like a reasonable feature. If you want to implement it, I'd probably merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants