[Bug]: Deprecated-warning IcingaDbGrapher.php

[tectumopticum]

Please try to fill out as much of the information below as you can. Thank you!

• Yes, I've searched similar issues on GitHub and didn't find any.

Which version contains the bug?

3.0.0

Describe the bug

If a panel doesn't contain data, a "deprecated"-warning is shown:

Deprecated
: substr_count(): Passing null to parameter #1 ($haystack) of type string is deprecated in
/usr/share/icingaweb2/modules/grafana/library/Grafana/ProvidedHook/Icingadb/IcingaDbGrapher.php
on line
381

How to recreate the bug?

In icingaweb2 choose a service where no data is delivered, e.g. a IfW-check like "Invoke-IcingaCheckUsedPartitionSpace" for a partition the monitoring-user doesn't have access.
A resulting URL could be
https://:3000/d/lwrZmQF4k/disk?var-hostname=&var-service=disk%20D%3A%2F&var-command=Invoke-IcingaCheckUsedPartitionSpace&from=now-6h&to=now&orgId=1&viewPanel=1,0

[RincewindsHat]

Just had a short look at the code at this point and it looks like there is a check missing whether there are actually any perfdata available [0].
This could probably be introduced earlier, since we can exit early if there is no data at all.

[0]

icingaweb2-module-grafana/library/Grafana/ProvidedHook/Icingadb/IcingaDbGrapher.php

Line 381 in 677fada

intval(substr_count($object->state->performance_data, '=') / $this->numberMetrics);

[martialblog]

Hi, yes probably due to the value being null. I'll provide a fix

[martialblog]

@tectumopticum This should fix the issue #44 - can you confirm that?