Build failure: midori-unwrapped

[ShamrockLee]

Nixpkgs version

• Unstable (25.05)

Steps to reproduce

nix build --no-link --print-out-paths -L github:NixOS/nixpkgs/e74f78961d1c042204272b6561c75a9a00aaa42a#midori-unwrapped

Can Hydra reproduce this build failure?

Yes, Hydra can reproduce this build failure.

Link to Hydra build job

https://hydra.nixos.org/build/281347313

Relevant log output

Compilation succeeded - 3 warning(s)
[35/156] Generating colorful-tabs.c
[36/156] Generating session.c
[37/156] Generating status-clock.c
[38/156] Generating statusbar-features.c
[39/156] Generating database.c
[40/156] Generating web-extensions.c
[41/156] Building C object web/CMakeFiles/activatable.dir/loggable.c.o
[42/156] Building C object web/CMakeFiles/activatable.dir/plugins.c.o
[43/156] Building C object web/CMakeFiles/activatable.dir/settings.c.o
[44/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/filter.c.o
[45/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/extension.c.o
[46/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/keys.c.o
[47/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/options.c.o
[48/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/pattern.c.o
[49/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/settings.c.o
[50/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/subscription.c.o
[51/156] Building C object extensions/CMakeFiles/adblock.dir/adblock/whitelist.c.o
[52/156] Building C object extensions/CMakeFiles/colorful-tabs.dir/colorful-tabs.c.o
[53/156] Building C object extensions/CMakeFiles/bookmarks.dir/bookmarks.c.o
[54/156] Building C object extensions/CMakeFiles/session.dir/session.c.o
FAILED: extensions/CMakeFiles/session.dir/session.c.o 
/nix/store/xcn9p4xxfbvlkpah7pwchpav4ab9d135-gcc-wrapper-14-20241116/bin/gcc -DGCR_API_SUBJECT_TO_CHANGE -DGETTEXT_PACKAGE=\"midori\" -Dsession_EXPORTS -I/build/midori-v9.0 -I/build/midori-v9.0/core -I/nix/store/y8fxzs8srzd6d74a85zbpssjr8wkj9q4-glib-2.82.1-dev/include/glib-2.0 -I/nix/store/rb870mk51kxlxq9crkldzs8n4vwr9sk4-glib-2.82.1/lib/glib-2.0/include -I/nix/store/zmqxpcxhcd5r7qr5gvp6vrigmiwhjaw8-libsoup-2.74.3-dev/include/libsoup-2.4 -I/nix/store/q71pkk2b2mg8n326cs0zdlwdil2b27fl-gtk+3-3.24.43-dev/include/gtk-3.0 -I/nix/store/zviv60hd5v5qggfbl0n20nwlkzzvvyyq-at-spi2-core-2.54.0-dev/include/atk-1.0 -I/nix/store/l0np4qv5260igzj1z5cz4j936i29bn1j-cairo-1.18.2-dev/include/cairo -I/nix/store/wc97xp20zf23vx6rj65ah6knqpqwn9bn-freetype-2.13.3-dev/include/freetype2 -I/nix/store/v5flgachjhgvsxqxqi8hnpi19cnbgfwc-gdk-pixbuf-2.42.12-dev/include/gdk-pixbuf-2.0 -I/nix/store/akxwqfa5h9n4giv2zp04m3v4ngabb18j-pango-1.54.0-dev/include/pango-1.0 -I/nix/store/9w2ars9rx8k0y48pq9fbmqxypmmfga3q-harfbuzz-10.1.0-dev/include/harfbuzz -I/nix/store/inzck7yikz71bhwfgqzdpcj04jpwykvv-gcr-3.41.2-dev/include/gcr-3 -I/nix/store/inzck7yikz71bhwfgqzdpcj04jpwykvv-gcr-3.41.2-dev/include/gck-1 -I/nix/store/v361qsdmlndpf71yimfkvqxw265dkjbl-p11-kit-0.25.5-dev/include/p11-kit-1 -I/nix/store/ha9jj7cqfcl45wrf1p25rbz4cii1pc0s-libpeas-1.36.0-dev/include/libpeas-1.0 -I/nix/store/z0l3mj7jwhhk5hg4q4c99akrc1zc4yiy-gobject-introspection-1.82.0-dev/include/gobject-introspection-1.0 -I/nix/store/k18p1ir7r8hg2jrz1w7aiafs8vda3rpp-webkitgtk-2.46.5+abi=4.0-dev/include/webkitgtk-4.0 -I/nix/store/9hh147nbjc7z7qlpbkbf97iay9zbmwag-json-glib-1.10.0-dev/include/json-glib-1.0 -I/build/midori-v9.0/build -I/build/midori-v9.0/build/core -I/build/midori-v9.0/build/extensions -O3 -DNDEBUG -fPIC -g -fPIC -w -Werror -MD -MT extensions/CMakeFiles/session.dir/session.c.o -MF extensions/CMakeFiles/session.dir/session.c.o.d -o extensions/CMakeFiles/session.dir/session.c.o -c /build/midori-v9.0/build/extensions/session.c
/build/midori-v9.0/extensions/session.vala: In function 'tabby_session_database_get_items_co':
/build/midori-v9.0/extensions/session.vala:73:75: error: passing argument 3 of 'g_object_set_data_full' makes pointer from integer without a cast [-Wint-conversion]
   73 |                 item.set_data<int64> ("session_id", session_id);
      |                                                                           ^           
      |                                                                           |
      |                                                                           gint64 {aka long int}
In file included from /nix/store/y8fxzs8srzd6d74a85zbpssjr8wkj9q4-glib-2.82.1-dev/include/glib-2.0/gobject/gbinding.h:31,
                 from /nix/store/y8fxzs8srzd6d74a85zbpssjr8wkj9q4-glib-2.82.1-dev/include/glib-2.0/glib-object.h:24,
                 from /build/midori-v9.0/build/core/midori-core.h:6,
                 from /build/midori-v9.0/build/extensions/session.c:15:
/nix/store/y8fxzs8srzd6d74a85zbpssjr8wkj9q4-glib-2.82.1-dev/include/glib-2.0/gobject/gobject.h:603:64: note: expected 'gpointer' {aka 'void *'} but argument is of type 'gint64' {aka 'long int'}
  603 |                                                gpointer        data,
      |                                                ~~~~~~~~~~~~~~~~^~~~
/build/midori-v9.0/extensions/session.vala:74:71: error: passing argument 3 of 'g_object_set_data_full' makes pointer from integer without a cast [-Wint-conversion]
   74 |                 item.set_data<int64> ("pinned", statement.get_int64 ("pinned"));
      |                                                                 ~~~~~~^~~~~~~~~
      |                                                                       |
      |                                                                       gint64 {aka long int}
/nix/store/y8fxzs8srzd6d74a85zbpssjr8wkj9q4-glib-2.82.1-dev/include/glib-2.0/gobject/gobject.h:603:64: note: expected 'gpointer' {aka 'void *'} but argument is of type 'gint64' {aka 'long int'}
  603 |                                                gpointer        data,
      |                                                ~~~~~~~~~~~~~~~~^~~~
/build/midori-v9.0/extensions/session.vala: In function 'tabby_session_database_restore_windows_co':
/build/midori-v9.0/extensions/session.vala:214:16: error: assignment to 'gint64' {aka 'long int'} from 'gconstpointer' {aka 'const void *'} makes integer from pointer without a cast [-Wint-conversion]
  214 |                 int64 id = item.get_data<int64> ("session_id");
      |                ^
/build/midori-v9.0/extensions/session.vala: In function 'tabby_session_database_tab_added_co':
/build/midori-v9.0/extensions/session.vala:285:73: error: passing argument 3 of 'g_object_set_data_full' makes pointer from integer without a cast [-Wint-conversion]
  285 |             item.set_data<int64> ("session_id", id);
      |                                                                         ^   
      |                                                                         |
      |                                                                         gint64 {aka long int}
/nix/store/y8fxzs8srzd6d74a85zbpssjr8wkj9q4-glib-2.82.1-dev/include/glib-2.0/gobject/gobject.h:603:64: note: expected 'gpointer' {aka 'void *'} but argument is of type 'gint64' {aka 'long int'}
  603 |                                                gpointer        data,
      |                                                ~~~~~~~~~~~~~~~~^~~~
[55/156] Building C object extensions/CMakeFiles/status-clock.dir/status-clock.c.o
ninja: build stopped: subcommand failed.

Additional context

No response

System metadata

• system: "x86_64-linux"
• host os: Linux 6.6.66, NixOS, 24.11 (Vicuna), 24.11.20241216.3945713
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.24.10
• nixpkgs: /nix/store/wj2qla569hnxwqfc26imv5hqbxc1rc27-source

Notify maintainers

@7c6f434c @RamKromberg

I assert that this issue is relevant for Nixpkgs

• I assert that this is a bug and not a support request.
• I assert that this is not a duplicate of an existing issue.
• I assert that I have read the NixOS Code of Conduct and agree to abide by it.

Is this issue important to you?

Add a 👍 reaction to issues you find important.

[ghpzin]

This could be a good point to drop this package altogether as seemingly upstream switched direction to doing "firefox fork" instead:
midori-browser/core#468
flathub/org.midori_browser.Midori#23
flathub/org.midori_browser.Midori@34b6c5e
https://github.com/goastian/midori-desktop
and keeping web browser with no upstream support for 5 years does not seem that great.

[7c6f434c]

Anything related to importance of upstream support is in the engine anyway. But yeah, if building it with updated dependencies is no longer simple, dropping makes sense.