Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap errors correctly so that users get readable transaction failures #251

Open
EricBolten opened this issue Oct 21, 2021 · 0 comments
Open

Comments

@EricBolten
Copy link
Contributor

Original issue

https://github.com/althea-net/cosmos-gravity-bridge/pull/323/files

The content of this pr is an example of an error type that would not be returned correctly to the user. In the before case the user would see an 'unknown internal error' in the response for their transaction if they hit this error case.

If the error is wrapped properly the user will see the error message in the 'raw_log' section of the tx response, greatly easing debugging.

There are many instances in the codebase of this mistake, and the above example pr only corrects one of them. This ticket is for the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant