Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make orthogonalizer and SVD responsible for reshaping #134

Open
eparish1 opened this issue Feb 12, 2024 · 0 comments
Open

Make orthogonalizer and SVD responsible for reshaping #134

eparish1 opened this issue Feb 12, 2024 · 0 comments

Comments

@eparish1
Copy link
Contributor

Currently our VectorSpace implementations have a _tensor_to_matrix that reshapes the snapshots into a matrix before, e.g., the orthogonalizer or SVD is hit. For consistent APIs, we propose that these reshapes should be performed within the orthogonalizer and SVD classes.

We will work on this after #70 is pulled in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eparish1