New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

which opereations to do in place and which ones should return #140

Open

fnrizzi opened this issue Feb 15, 2024 · 1 comment

Member

fnrizzi commented Feb 15, 2024

we have:

splitter
shifter
scaler
orthogonalizer
truncater

which ones should be made to act in place vs return the result?

The text was updated successfully, but these errors were encountered:

Contributor

eparish1 commented Feb 15, 2024

splitter: can't be in place; also hoping to ax this so let's not worry for now.
shifter: in place
scaler: in place
orthogonalizer: can't fully be made in place, but I think we could maybe overwrite the object passed in.
truncater: same comment as orthogonalizer. Maybe we use np.delete to delete columns instead of returning a new object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment