Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Move Dependencies to NPM and bundle using Browserify #126

Open
maxdumas opened this issue Oct 3, 2015 · 1 comment
Open

Move Dependencies to NPM and bundle using Browserify #126

maxdumas opened this issue Oct 3, 2015 · 1 comment
Assignees

Comments

@maxdumas
Copy link
Member

maxdumas commented Oct 3, 2015

Trying to solve #125 & #119 has made me realize that our dependencies are kind of a mess right now. Keeping track of which versions we're using, making sure they load in the correct order, and request-bombardment are all becoming issues. Using Browserify is a smart move in the long run and it will make our code a lot more reusable and our dependencies centrally managed. I also think it will directly fix the flaky behavior that we're seeing in #119.

That said, we would need to modify the deploy script to invoke browserify in some way. I'm not totally sure what is available to us from CircleCI; it looks like we're auto-provisioning turbolift to execute the deploy right now. Can we execute npm scripts from CircleCI? @AbhiAgarwal

@maxdumas maxdumas self-assigned this Oct 3, 2015
@AbhiAgarwal
Copy link
Member

Hey @maxdumas! Yup :) We can run npm scripts from CircleCI.

Just let me know the commands to put in and what we need to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants