Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how dynamic page titles are set #677

Open
jtucholski opened this issue Jan 19, 2025 · 0 comments
Open

Refactor how dynamic page titles are set #677

jtucholski opened this issue Jan 19, 2025 · 0 comments
Assignees
@corypride
Labels
refactor - frontend

Comments

@jtucholski
Copy link
Contributor

In PR #657 we exposed a global setter for the Page Nav component in order to display the Library title as the Page Nav title.

React conventions typically follow one of two approaches for allowing components to communicate with each other.

  1. Lift state up
  2. Pass with context

Since PageNav and each page is added to AuthenticatedLayout, then listing state up is the preferred option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corypride corypride

Labels
refactor - frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtucholski @corypride