Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate SVG for shapes with diamond and angle gradient #25

Open
imaderyc opened this issue Aug 23, 2014 · 5 comments
Open

Inaccurate SVG for shapes with diamond and angle gradient #25

imaderyc opened this issue Aug 23, 2014 · 5 comments

Comments

@imaderyc
Copy link

https://www.dropbox.com/s/uz57kd84nyqv5l9/otherGradients.psd?dl=0
(simple rectangles with gradient/diamond and angle fills)

  1. generate assets, set SVG files
    Result: SVG files are empty
@jhatwich
Copy link
Contributor

Renamed from Empty to Inaccurate since it isn't empty any more but it isn't right either 🐛

@jhatwich jhatwich added the bug label Aug 25, 2014
@jhatwich jhatwich changed the title empty SVG for shapes with diamond and angle gradient Inaccurate SVG for shapes with diamond and angle gradient Aug 25, 2014
@dirkschulze
Copy link
Contributor

This is either a WONT FIX or we should export a PNG for the layer. It is simply not possible to export it.

IMO, we should keep this bug open but let the output as is. This seems more useful. Authors can fallback to PNG export.

@jhatwich
Copy link
Contributor

@dirkschulze do you think we should make a preference where-by we rasterize any layers we know to be unsupported?

@dirkschulze
Copy link
Contributor

It is really hard to tell. We do not have precise rendering for most strokes, since the default stroke offset is not middle like in SVG. (Which happens to be the only option in SVG anyway.) Should we export a PNG in this case? I don't think so.

What about patterns, emboss and bevel? We can create a PNG in these cases as well, I am just not sure what the author expects. After all, the author can use PNG export in these cases.

On the other hand, Illustrator always exports PNG for things that do not look the same.

My personal, current preference is to keep the current behavior for all these things.

@jhatwich
Copy link
Contributor

Seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants