Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ refactor ] move Data.List.Relation.Binary.Permutation.Setoid.Properties.foldr-commMonoid to Data.List.Effectful.Foldable? #2560

Open
jamesmckinna opened this issue Jan 20, 2025 · 0 comments

Comments

@jamesmckinna
Copy link
Contributor

Thinking about #2558 / #2553 has led me to the conclusion that this lemma (introduced rather hastily by me in its current form during the refactoring of Data.Nat.Primality.Factorisation #1969, cf. also #2498) belongs not under Permutation.Setoid.Properties, but would fit 'better' in a scope where (Commutative)Monoid is already part of the ambient mathematical context, viz. as a(n additional) property of the Foldable structure on List.

Separately, and perhaps independent of the above consideration, the dependency structure of both the definition, and its use, is horrendous, relying as it does on the uneasy negotiation between the Structure and Bundle views of CommutativeMonoid, essentially only so that Relation.Binary.Reasoning.Setoid can be deployed... so there might be wider considerations of how we parametrise such modules... on the Bundle, or on the Structure (and the sense that it 'shouldn't matter', but alas, it does)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant