Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if Dataflow template file writing fails. #33684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baeminbo
Copy link
Contributor

@baeminbo baeminbo commented Jan 21, 2025

Fix #33636


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@baeminbo
Copy link
Contributor Author

This fixes GCS upload errors are swallowed in PrintWriter at DataflouwRunner.run().

To test the fix, the unit tests mock the static method FileSystems.create() in DataflowRunnerTest. For this, Mockito.mockStatic is used instead of PowerMockito.mockStatic so that we don't need PowerMockRunner anymore for some unit tests that mock static methods.

The dependency mockito-core was replaced by mockito-inline for the Mockito.mockStatic change.

I changed DataflowPipelineOptionsTest as well to remove the usage of PowerMockito.mockStatic. I fixed some warnings such as unnecessary type conversion, unthrown exceptions, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The output reports success when Dataflow template creation is not successful
1 participant