Skip to content
This repository has been archived by the owner on Apr 10, 2021. It is now read-only.

The Lambda Editor isn't fully visible in Firefox #228

Open
tokarzkj opened this issue Mar 10, 2020 · 1 comment
Open

The Lambda Editor isn't fully visible in Firefox #228

tokarzkj opened this issue Mar 10, 2020 · 1 comment

Comments

@tokarzkj
Copy link
Contributor

tokarzkj commented Mar 10, 2020

Describe the bug
When creating a lambda in the client app the editor is only a few pixels tall.

To Reproduce
Steps to reproduce the behavior:

  1. Open Firefox (in my case 73.0.1 64-bit)
  2. Click on Lambdas
  3. Create or edit a lambda
  4. The editor will be barely visible

Expected behavior
The editor should be fully visible to the bottom of the window

Screenshots
image

Desktop:

  • OS: e.g. iOS, Windows, Linux

  • Browser chrome

  • Version 79.0.3945

  • OS: e.g. iOS, Windows, Linux

  • Browser firefox

  • Version 72.0.2

Additional context
Add any other context about the problem here.

@Dansr81
Copy link
Contributor

Dansr81 commented Mar 17, 2020

The editor height and width never refreshed on window resize and minimum height is not set.

  1. resize the browser window
  2. Create or edit a lambda
  3. resize the browser window

the editor is not refreshed

Possible solution:
open file src\modules\core\components\lambda-details\lambda-details.js

  1. add a event listner on window resize:
    mounted: function () { window.addEventListener("resize", this.resizeCustomMonaco); }

  2. in resizeCustomMonaco change
    const newHeight
    with
    var newHeight
    (const: value is immutable; var: value is mutable)

  3. check the newHeight value (in the example the minimum height is 100)
    if (newHeight < 100) { newHeight = 100; } monacoEditor.layout({ width: oldLayout.width, height: newHeight });

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants