Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portal] discuss url structure, theming #56

Open
rt2zz opened this issue Mar 9, 2018 · 2 comments
Open

[portal] discuss url structure, theming #56

rt2zz opened this issue Mar 9, 2018 · 2 comments

Comments

@rt2zz
Copy link
Member

rt2zz commented Mar 9, 2018

right now we put the thin auth api key in the url - but ideally we support custom domains, or sub-domains.

One idea I had to support this is we can add "authDomain" to tenants, then for certain requests rather than requiring apiKey we can instead read the request domain and do a tenant lookup that way.

There may be other / better solutions as well.

@cjcaj
Copy link
Contributor

cjcaj commented Mar 9, 2018

authDomain in tenants sounds like the correct solution for now.
For theming, could we have another JSON column themeConfig that will have only logoUrl. I'm thinking that theming should be pretty minimal here but could use the flexibility that JSON provides versus having it as a column.

@rt2zz
Copy link
Member Author

rt2zz commented Mar 9, 2018

agree - super simple on the theming. maybe just logo + primary color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants