Rework auctionhouse Update causes people to be kicked if buy to many items at once

[TheSCREWEDSoftware]

Issue linked from CC: chromiecraft/chromiecraft#7657

Triage Notes: chromiecraft/chromiecraft#7657 (comment)

• I tested this with 2 different accounts.
• Made sure the "buyer" account had auctionator
• The "seller" account would have 40 linen clothes (.additem 2589 40) and would make 40 stacks of 1 auctions with 10 copper for bid and 20 bid for buyout (you will need to .modify money 100g)
• With the buyer try buying 11 linen clothes, you will be kicked but the items will be in your mail still (no error on the the worldserver)

Original Post Below:

---

What client do you play on?

enUS

Faction

Alliance

Content Phase:

Generic

Current Behaviour

Buying 10 or more items at the same time from AH using Auctionator disconnects the player. Items are succesfully bought and can be found in mailbox after relog.

This problem started happening on Chromiecraft within the last month or so. For some reason server kicks the player. I did the same tests on other 3.3.5a servers with the same addon and there's no such issue.

Expected Blizzlike Behaviour

Server shouldn't kick the player.

Source

No source required.

Steps to reproduce the problem

1. Install Auctionator addon (from Felbite or somewhere else)
2. Login to chromiecraft live server
3. On "Buy" tab, search for an item of which you can buy 10 or more (eg. Light Armor Kit, any potion etc.). It has to be 10 x 1 (10 stacks of 1) and not 1 x 10 (1 stack of 10) (Screenshot: https://imgur.com/a/CGKe6Py)
4. Enter the amount to buy (10+) and click buy.
5. You are disconnected.

Extra Notes

There are different working versions of Auctionator but it doesn't matter which one you are using for this test. I will put 2 links below for easy downloading:
1- https://forum.warmane.com/showthread.php?t=412904&p=3030654&viewfull=1#post3030654
2- https://felbite.com/addon/4868-auctionator/

AC rev. hash/commit

chromiecraft@5f020de

Operating system

Ubuntu 22.04

Modules

• mod-1v1-arena
• mod-ah-bot
• mod-anticheat
• mod-arena-3v3-solo-queue
• mod-arena-replay
• mod-bg-item-reward
• mod-breaking-news-override
• mod-cfbg
• mod-chat-transmitter
• mod-chromie-xp
• mod-costumes
• mod-cta-switch
• mod-desertion-warnings
• mod-dmf-switch
• mod-duel-reset
• mod-eluna
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-npc-spectator
• mod-progression-system
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-CarbonCopy
• lua-eventScripts
• lua-ExchangeNpc
• lua-LevelUpReward
• lua-RecruitAFriend
• lua-SendAndBind
• lua-TempAnnouncements
• lua-Zonecheck

Customizations

None

Server

ChromieCraft

[TheSCREWEDSoftware]

CC: @Takenbacon

[Takenbacon]

AH Query packets were added to the throttler (here: https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/game/Server/WorldSession.cpp#L1551-L1553). I'm guessing a buy also seems to send a query request. We can just increase the limits for now, it was noted in the AH PR that the current packet throttler implementation is not ideal for this use case to begin with but that'll need a good bit more work to properly handle.

[skelUA]

also not woring searching usable items
test on druid
with filter

witout filter

[skelUA]

cc: @Takenbacon

[Takenbacon]

@skelUA I won't have time to look into it for a while, but it should be easy to debug and fix. Check here https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/game/AuctionHouse/AuctionHouseSearcher.cpp#L663