Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current physical/statistical phasing WDLs. #2

Closed
samuelklee opened this issue Jul 24, 2024 · 5 comments · Fixed by #9
Closed

Add current physical/statistical phasing WDLs. #2

samuelklee opened this issue Jul 24, 2024 · 5 comments · Fixed by #9
Assignees

Comments

@samuelklee
Copy link
Collaborator

To support #1. Please include any version information and links in the PR, if possible.

@SHuang-Broad
Copy link
Collaborator

Does this work:
Link to the WDL residing in Hang's branch in this repo.
The phasing WDL imports other WDL files in that repo, so a literal copy might introduce fragmentation.

@samuelklee
Copy link
Collaborator Author

I think at this point a forked copy of the phasing-specific WDLs is warranted to speed development without having to worry about working in multiple repos. These WDLs are not currently being used in any other projects, correct? (In fact, I believe they are still living on a branch?)

If there are non-specific tasks, then perhaps just copying those tasks into this forked copy (perhaps accompanied by a comment) for now is fine. If those tasks are relatively stable, then when we move everything back to the original repo, it should be relatively easy to restore the dependencies. We might also want to rebase the branch or otherwise check that those dependencies are not already out of date (i.e., if they have been updated in the main branch).

@SHuang-Broad
Copy link
Collaborator

SHuang-Broad commented Jul 25, 2024

sounds reasonable.

I see in #9 @hangsuUNC did brought in all the WDL files used.
I think a better approach would be to consolidate all the needed tasks into a single WDL.

Thoughts? @samuelklee @hangsuUNC

@samuelklee
Copy link
Collaborator Author

Yes, I think moving all used tasks into a temporary task WDL that will only live in this repo should be fine. Alternatively, just place each task in its corresponding phasing-specific sub/WDLs as appropriate.

I’d recommend stripping out extraneous tasks like file finalization and keeping things minimal for now. I expect that we will want to do a round of refactoring (I think Hang and I discussed previoisly that some of the file-naming conventions could be changed to aid downstream analyses), followed by a round of dev work to start addressing the multiallelics.

@hangsuUNC
Copy link
Collaborator

sounds reasonable.

I see in #9 @hangsuUNC did brought in all the WDL files used. I think a better approach would be to consolidate all the needed tasks into a single WDL.

Thoughts? @samuelklee @hangsuUNC

sounds good to me.

@hangsuUNC hangsuUNC linked a pull request Jul 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants