-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current physical/statistical phasing WDLs. #2
Comments
Does this work: |
I think at this point a forked copy of the phasing-specific WDLs is warranted to speed development without having to worry about working in multiple repos. These WDLs are not currently being used in any other projects, correct? (In fact, I believe they are still living on a branch?) If there are non-specific tasks, then perhaps just copying those tasks into this forked copy (perhaps accompanied by a comment) for now is fine. If those tasks are relatively stable, then when we move everything back to the original repo, it should be relatively easy to restore the dependencies. We might also want to rebase the branch or otherwise check that those dependencies are not already out of date (i.e., if they have been updated in the main branch). |
sounds reasonable. I see in #9 @hangsuUNC did brought in all the WDL files used. Thoughts? @samuelklee @hangsuUNC |
Yes, I think moving all used tasks into a temporary task WDL that will only live in this repo should be fine. Alternatively, just place each task in its corresponding phasing-specific sub/WDLs as appropriate. I’d recommend stripping out extraneous tasks like file finalization and keeping things minimal for now. I expect that we will want to do a round of refactoring (I think Hang and I discussed previoisly that some of the file-naming conventions could be changed to aid downstream analyses), followed by a round of dev work to start addressing the multiallelics. |
sounds good to me. |
To support #1. Please include any version information and links in the PR, if possible.
The text was updated successfully, but these errors were encountered: