Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MAC>=2 filtering before and after HiPhase #40

Open
hangsuUNC opened this issue Sep 9, 2024 · 2 comments
Open

Test MAC>=2 filtering before and after HiPhase #40

hangsuUNC opened this issue Sep 9, 2024 · 2 comments
Assignees

Comments

@hangsuUNC
Copy link
Collaborator

Will it change performance when doing MAC>=2 filtering before and after Hiphase? Doing filtering before Hiphase may reduce computational burden.

@hangsuUNC
Copy link
Collaborator Author

hangsuUNC commented Sep 25, 2024

Here is the comparison based on main branch. The first panel of results is MAC filtering after hiphase, the second panel is MAC filtering before hiphase. You may notice SNP and indel recall drops but after shapeit, SV recall is improved.

image

@samuelklee
Copy link
Collaborator

What was the conclusion? Also, I’m not sure I understand the color coding above. Does [green, red] cover [0, 1] identically for each table? If so, this is a bit counterintuitive. I might instead suggest shading just the second table relative to the first, with green and red indicating increased and decreased performance, respectively.

@samuelklee samuelklee reopened this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants