You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Usage of the former is discouraged since samtools and bcftools versions can fall out of sync, potentially causing incompatibilities in variant calling pipelines connecting samtools mpileup to bcftools call (which we don't, but it's why bcftools is now the recommended mpileup). Additionally, some parameters (ex. -L) samtools once offered have been deprecated in newer versions (this does affect our usage of samtools mpileup).
bcftools mpileup is the current alternative, however it cannot emit the simple tabular "pileup" format we currently ingest from samtools mpileip; bcftools mpileup currently only writes vcf, bcf, and compressed versions of those formats. Code underpinning bcftools mpileup is derived from a prior version of samtools mpileup, so the parameters we pass will need little to no change to suit bcftools mpileup, but changes will need to be made to viral-phylo to parse the info needed from the (v|b)cf files written by bcftools mpileup.
NB: This connects to #28 and a desired migration away from V-Phaser2 for iSNV calling. This PR and the switch to bcftools mpileup may be unnecessary if we can use vcfs from a tool like LoFreq directly rather than create them ourselves as we are in intrahost.py::merge_to_vcf() (using V-Phaser2 output).
The text was updated successfully, but these errors were encountered:
In
intrahost.py::get_mpileup_allele_counts()
(called directly inintrahost.py::compute_library_bias()
, and ultimately used byintrahost.py::vphaser_one_sample
for reporting per-library allele depths):samtools mpileup
tobcftools mpileup
Usage of the former is discouraged since samtools and bcftools versions can fall out of sync, potentially causing incompatibilities in variant calling pipelines connecting
samtools mpileup
tobcftools call
(which we don't, but it's why bcftools is now the recommendedmpileup
). Additionally, some parameters (ex.-L
) samtools once offered have been deprecated in newer versions (this does affect our usage ofsamtools mpileup)
.bcftools mpileup
is the current alternative, however it cannot emit the simple tabular "pileup" format we currently ingest fromsamtools mpileip
;bcftools mpileup
currently only writes vcf, bcf, and compressed versions of those formats. Code underpinningbcftools mpileup
is derived from a prior version ofsamtools mpileup
, so the parameters we pass will need little to no change to suitbcftools mpileup
, but changes will need to be made to viral-phylo to parse the info needed from the (v|b)cf files written bybcftools mpileup
.NB: This connects to #28 and a desired migration away from V-Phaser2 for iSNV calling. This PR and the switch to
bcftools mpileup
may be unnecessary if we can use vcfs from a tool like LoFreq directly rather than create them ourselves as we are inintrahost.py::merge_to_vcf()
(using V-Phaser2 output).The text was updated successfully, but these errors were encountered: