fix lifecycle change summarizer to show relocated image #193
Conversation
there is some, it basically just creates a descriptor with some changes. It's probably worth adding a test that contains a digest |
tomkennedy513
force-pushed
the
lifecycle-change-summarizer
branch
from
983091f to
9dbc939
Compare
pkg/import/import_differ.go
Outdated
| @@ -33,8 +35,19 @@ type ImportDiffer struct { | |||
| StackRefGetter StackRefGetter | |||
| } | |||
|
|
|||
| func (id *ImportDiffer) DiffLifecycle(oldImg string, newImg string) (string, error) { | |||
| return id.Differ.Diff(oldImg, newImg) | |||
| func (id *ImportDiffer) DiffLifecycle(kpConfig config.KpConfig, oldImg string, newImg string) (string, error) { | |||
There was a problem hiding this comment.
It seems that the other methods in in here DiffClusterStore/DiffClusterStack/etc are actually reading the fully qualified digest from the registry so the lack of a similar workflow feels out of place here.
There was a problem hiding this comment.
These other calls do feel awkward because the other differs use StackRefGetter/StoreRefGetter which seem to be "too knowledgeable" about the intended usecase of an image (whether it is a stack/buildpack/etc).
There was a problem hiding this comment.
Perhaps this all could be simplified if we don't need to give the relocated images "pretty names" and we can write them all to the same repo in the registry.
tomkennedy513
force-pushed
the
lifecycle-change-summarizer
branch
from
9dbc939 to
f775de8
Compare
|
closing as this was resolved in #205 |
fixes #187