[Request] mgba-git

[Evil95]

Package

https://aur.archlinux.org/pkgbase/mgba-git

Purpose

Emulator to play gb, gbc and gba games.

License

MPL-2.0

Submission checklist

• The package is not banned.
• The package is not available in Chaotic AUR or official Arch repos.
• The package has not already been requested.

[Technetium1]

@xiota strange pkgver, thoughts?

[xiota]

It's parsing a file for the "development version" and using total commit count. I don't like this type of system because dev version numbers > corresponding release, even though they're really older (0.11.0.r8409 > 0.11.0).

I prefer to count revisions from last stable version. This is what the standard git describe usually produces, unless upstream tags releases in separate branches. Then I use something like the following:

_pkgsrc="mgba"
pkgver() {
  cd "$_pkgsrc"
  _tag=$(git tag | grep -Ev '[a-z][a-z]' | sort -rV | head -1)
  _version="${_tag:?}"
  _revision=$(git rev-list --count --cherry-pick "$_tag"...HEAD)
  _hash=$(git rev-parse --short=7 HEAD)
  printf '%s.r%s.g%s' "${_version:?}" "${_revision:?}" "${_hash:?}"
}

Unless definitely spelled out in package guidelines (remove v prefix), difficult to convince maintainers to fix bad pkgver(). If that's the only thing wrong with a package, can add corrected pkgver() to interfere.

[Technetium1]

I agree that it's a good idea to interfere and fix that if it will be added. I don't like it as is.