You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When our C3 e2e tests run, they (in a nutshell) build C3 out of the main branch, and create a starter project (via that previously built executable) for each framework under test. Once the starter project is created, certain assertions are made on it.
A starter project will come with a list of predefined dependencies, necessary for the project to run and be deployed, defined in package.json. All (I think) C3 starter projects will have a dependency on wrangler, specifically, on the latest released version of wrangler, wrangler@latest. This is crucial to note here, because while the C3 e2e tests are running in the "context" of a wrangler built off of main (let's call this version N), they are in fact making assertions against starter projects that were built with wrangler version N-1 (wrangler@latest).
In our case this resulted in a false positive CI run, where C3 e2e tests were successful, when they should have instead failed
The text was updated successfully, but these errors were encountered:
see #7797 for reference
When our C3 e2e tests run, they (in a nutshell) build C3 out of the main branch, and create a starter project (via that previously built executable) for each framework under test. Once the starter project is created, certain assertions are made on it.
A starter project will come with a list of predefined dependencies, necessary for the project to run and be deployed, defined in
package.json
. All (I think) C3 starter projects will have a dependency onwrangler
, specifically, on the latest released version ofwrangler
,wrangler@latest
. This is crucial to note here, because while the C3 e2e tests are running in the "context" of a wrangler built off ofmain
(let's call this versionN
), they are in fact making assertions against starter projects that were built with wrangler versionN-1
(wrangler@latest
).In our case this resulted in a false positive CI run, where C3 e2e tests were successful, when they should have instead failed
The text was updated successfully, but these errors were encountered: