Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure C3 E2E tests run against a locally built version of Wrangler #7800

Open
penalosa opened this issue Jan 16, 2025 · 0 comments · May be fixed by #7809
Open

Ensure C3 E2E tests run against a locally built version of Wrangler #7800

penalosa opened this issue Jan 16, 2025 · 0 comments · May be fixed by #7809
Assignees

Comments

@penalosa
Copy link
Contributor

penalosa commented Jan 16, 2025

see #7797 for reference

When our C3 e2e tests run, they (in a nutshell) build C3 out of the main branch, and create a starter project (via that previously built executable) for each framework under test. Once the starter project is created, certain assertions are made on it.

A starter project will come with a list of predefined dependencies, necessary for the project to run and be deployed, defined in package.json. All (I think) C3 starter projects will have a dependency on wrangler, specifically, on the latest released version of wrangler, wrangler@latest. This is crucial to note here, because while the C3 e2e tests are running in the "context" of a wrangler built off of main (let's call this version N), they are in fact making assertions against starter projects that were built with wrangler version N-1 (wrangler@latest).

In our case this resulted in a false positive CI run, where C3 e2e tests were successful, when they should have instead failed

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jan 16, 2025
@CarmenPopoviciu CarmenPopoviciu self-assigned this Jan 20, 2025
@CarmenPopoviciu CarmenPopoviciu moved this from Untriaged to In Progress in workers-sdk Jan 20, 2025
@CarmenPopoviciu CarmenPopoviciu moved this from In Progress to In Review in workers-sdk Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants