Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SOURCE_COMMIT empty after upgrade from 380 to 384 #4902

Closed
danielbarion opened this issue Jan 21, 2025 · 1 comment · Fixed by #4920
Closed

[Bug]: SOURCE_COMMIT empty after upgrade from 380 to 384 #4902

danielbarion opened this issue Jan 21, 2025 · 1 comment · Fixed by #4920

Comments

@danielbarion
Copy link

danielbarion commented Jan 21, 2025

Error Message and Logs

Hi guys, great job on the new releases!

Today I upgraded my self-hosted version of Coolify from beta v380 to v384, and after that upgrade, the deployment of my javascript app that uses the SOURCE_COMMIT env started to break, so after a few debugs I realized the source commit value now is an empty string:

Image

Image

my docker file:

FROM oven/bun:1.1.45-alpine AS base
RUN apk add --no-cache git
# WORKDIR /app

COPY package.json bun.lockb ./
# Make sure these files are present before installing
RUN bun install --frozen-lockfile

# Now copy the rest of your source code
COPY . .

FROM base AS build

# Declare the build argument
ARG SOURCE_COMMIT
# Set the environment variable using the build argument
ENV SOURCE_COMMIT=${SOURCE_COMMIT}

ENV NODE_ENV=production

# Run build script
RUN bun run build

FROM build AS release
USER bun
EXPOSE 3000/tcp
ENTRYPOINT [ "bun", "run", "server.ts" ]

Steps to Reproduce

  1. create a sample project and try to deploy it on Coolify using Docker
  2. try reading the SOURCE_COMMIT env and also log it for debugging purposes
  3. the value will be an empty string

Example Repository URL

No response

Coolify Version

v4.0.0-beta.384

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Ubuntu 24.04.1 LTS

Additional Information

I'm on the Discord server, please feel free to ping me if some extra information/details is needed (@barion)

@danielbarion danielbarion added 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Jan 21, 2025
@andrasbacsai
Copy link
Member

This will be fixed in the upcoming version.

@github-actions github-actions bot removed 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants