feat(preset): add preset template and rule for Hibernate JFR #750
+100
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-triage
andrewazores
added
feat
andrewazores
force-pushed
the
hibernate-jfr
branch
2 times, most recently
from
3e1c3ae to
a9b39c2
Compare
andrewazores
force-pushed
the
hibernate-jfr
branch
from
a9b39c2 to
ed78caf
Compare
|
This PR/issue depends on:
|
|
/build_test |
|
Workflow started at 1/13/2025, 1:54:56 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: At least one test failed ❌ |
|
Failure looks like hibernate/hibernate-orm#9180 . Checking if upgrading the |
|
/build_test |
|
Workflow started at 1/13/2025, 2:30:32 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
andrewazores
commented
Jan 13, 2025
andrewazores
force-pushed
the
hibernate-jfr
branch
from
e2bc8c0 to
7b4e2cb
Compare
andrewazores
force-pushed
the
hibernate-jfr
branch
from
7b4e2cb to
174ca15
Compare
Josh-Matsuoka
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #736
See also #548
Depends on #749
Based on #749
Description of the change:
Adds a Preset Event Template for Hibernate JFR events, which are enabled by the
hibernate-jfrdependency. Any application using Hibernate which also has this JAR on its classpath should have the relevant JFR event types registered, and they can be emitted simply by starting a recording with them enabled. Also adds an Automated Rule which detects the presence of these event types in the target JVM, for ease of enablement by the end user.Motivation for the change:
Provides a quick and easy way for Cryostat + Hibernate users to get very detailed profiling information about the internals of their Hibernate sessions, transactions, etc. - simply install the
hibernate-jfrdependency, redeploy the target application, and turn on the preset Automated Rule for Hibernate.How to manually test:
./smoketest.bash -Oauto_hibernaterecording should be started in Cryostat. Click around the UI a bunch to generate load, then download the recording.jfr print --events 'org.hibernate.orm.*' auto_hibernate.jfrshould reveal lots of JFR data.