New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward path retuns with None in case stack is > 2 #38

Open

Pet222 opened this issue Apr 28, 2022 · 1 comment

Pet222 commented Apr 28, 2022 •

edited

Loading

SCINet/models/SCINet.py

Line 373 in 1a3f231

elif self.stacks == 2:

In case the stack is > 2 it seems there is no return value given thus the forward path returns with None.

unclear how the test in table-6 was performed for stack > 2 when it is not implemented in the repo
suggestion: adding to the end of stack if-elif" a piece of code with "else raise NotImplementedError" would be useful.

Contributor

VEWOXIC commented Apr 28, 2022

Thanks for your asking.
We will check this problem with the code we are running on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment