Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to approve pr in the netlify-cms gui #1593

Open
ArcaneTSGK opened this issue Aug 8, 2018 · 4 comments · May be fixed by #6055
Open

Unable to approve pr in the netlify-cms gui #1593

ArcaneTSGK opened this issue Aug 8, 2018 · 4 comments · May be fixed by #6055
Labels
area: extensions/backends kind: enhancement pinned

Comments

@ArcaneTSGK
Copy link

- Do you want to request a feature or report a bug?
Feature

- What is the current behavior?
If the publish branch is a protected branch on GitHub, the content owner is unable to approve the pull request within the netlify-cms gui. Instead they have to go to GitHub and approve the pr there, which breaks their workflow experience.

- What is the expected behavior?
As most content teams are not developers or even tech savvy people, they should not be required to go into github to approve a pr, there should be a way to approve the changes within netlify-cms workflow itself.
@erquhart
Copy link
Contributor

Agreed, the GitHub backend should account for this.

@stale
Copy link

stale bot commented Oct 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Oct 29, 2019
@pmpinto
Copy link

pmpinto commented Dec 11, 2020

Additionally to what @ArcaneTSGK mentioned above, as it wasn't clear for me, I believe the user dragging the changes to the "Ready" column should be the user approving the PR in GitHub (through the backend).

@erquhart Any news on this? This is currently blocking our content team from managing their work themselves and relying on a team of developers to manually approve their content changes on GitHub insert sad kitten

@erezrokah
Copy link
Contributor

Hi @pmpinto, we're open to contributions for this issue. I would say it's a medium size effort to add an approve button to an editorial workflow entry that's only enabled for users that didn't author the entry

@erezrokah erezrokah mentioned this issue Apr 5, 2021
Closed
@mmkal mmkal linked a pull request Dec 15, 2021 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: extensions/backends kind: enhancement pinned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add approve PR button to workflow UI mmkal/decap-cms
4 participants
@erquhart @pmpinto @erezrokah @ArcaneTSGK