Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PTup_ should take a NonEmpty list of patterns #387

Open
byorgey opened this issue May 25, 2024 · 0 comments
Open

PTup_ should take a NonEmpty list of patterns #387

byorgey opened this issue May 25, 2024 · 0 comments
Labels
C-Low Hanging Fruit Shouldn't take too much time; ideal issues for new contributors. S-Nice to have Minor importance Z-Refactoring Z-Student Good project for a student.

Comments

@byorgey
Copy link
Member

byorgey commented May 25, 2024 •
edited
Loading

Disco does not support empty tuples (in fact, neither does it support 1-tuples), so to help get rid of warnings, avoid potential crashes, etc. the type we use to record tuple patterns should reflect this, using Data.List.NonEmpty.

For manipulating NonEmpty lists there are a bunch of functions (mostly paralleling functions on lists) here: https://hackage.haskell.org/package/base-4.21.0.0/docs/Data-List-NonEmpty.html
@byorgey byorgey added C-Low Hanging Fruit Shouldn't take too much time; ideal issues for new contributors. Z-Refactoring S-Nice to have Minor importance Z-Student Good project for a student. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Low Hanging Fruit Shouldn't take too much time; ideal issues for new contributors. S-Nice to have Minor importance Z-Refactoring Z-Student Good project for a student.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@byorgey