From 975450fc691f00dd446e705d598992b8671a0054 Mon Sep 17 00:00:00 2001 From: Randy Fay Date: Wed, 27 Feb 2019 12:41:25 -0700 Subject: [PATCH] Bump golang to 1.12 (#63) * Bump BUILD_IMAGE to 1.12 to get golang 1.12 * errcheck now works with modules, remove the skip in test --- makefile_components/base_build_go.mak | 2 +- tests/pkg/clean/build_tools_test.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/makefile_components/base_build_go.mak b/makefile_components/base_build_go.mak index 8a9a137..3b329e2 100644 --- a/makefile_components/base_build_go.mak +++ b/makefile_components/base_build_go.mak @@ -32,7 +32,7 @@ GOFILES = $(shell find $(SRC_DIRS) -name "*.go") BUILD_OS = $(shell go env GOHOSTOS) -BUILD_IMAGE ?= drud/golang-build-container:v1.11.4.2 +BUILD_IMAGE ?= drud/golang-build-container:v1.12 BUILD_BASE_DIR ?= $(PWD) diff --git a/tests/pkg/clean/build_tools_test.go b/tests/pkg/clean/build_tools_test.go index fc2a1c8..2944cd6 100644 --- a/tests/pkg/clean/build_tools_test.go +++ b/tests/pkg/clean/build_tools_test.go @@ -132,7 +132,6 @@ func TestGoVet(t *testing.T) { // Test errcheck. func TestErrCheck(t *testing.T) { - t.Skip("errcheck does not yet work with go 1.11 modules, see https://github.com/kisielk/errcheck/issues/155") a := assert.New(t) // pkg/dirtycomplex/bad_errcheck_code.go