From 6a1fcbcec09a41409b67c4c1270943d087256f45 Mon Sep 17 00:00:00 2001 From: "Mattan S. Ben-Shachar" Date: Sun, 26 May 2024 09:26:23 +0300 Subject: [PATCH] don't partialy match effect in parameters --- R/eta_squared-main.R | 6 +++--- R/eta_squared-methods.R | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/R/eta_squared-main.R b/R/eta_squared-main.R index 1f5d2447..ccb79efd 100644 --- a/R/eta_squared-main.R +++ b/R/eta_squared-main.R @@ -833,7 +833,7 @@ cohens_f_squared <- function(model, include_intercept = include_intercept ) - attr(out, "anova_type") <- tryCatch(attr(parameters::model_parameters(model, verbose = FALSE, effects = "fixed"), "anova_type"), + attr(out, "anova_type") <- tryCatch(attr(parameters::model_parameters(model, verbose = FALSE, effects = "fixed", effectsize_type = NULL), "anova_type"), error = function(...) 1 ) attr(out, "approximate") <- TRUE @@ -864,7 +864,7 @@ cohens_f_squared <- function(model, # TODO this should be in .anova_es.anvoa # TODO the aoc method should convert to an anova table, then pass to anova - params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed") + params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", effectsize_type = NULL) out <- .es_aov_simple(as.data.frame(params), type = type, partial = partial, generalized = generalized, @@ -890,7 +890,7 @@ cohens_f_squared <- function(model, verbose = TRUE, include_intercept = FALSE, ...) { - params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed") + params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", effectsize_type = NULL) anova_type <- attr(params, "anova_type") params <- as.data.frame(params) diff --git a/R/eta_squared-methods.R b/R/eta_squared-methods.R index 9368f4f6..82e945f5 100644 --- a/R/eta_squared-methods.R +++ b/R/eta_squared-methods.R @@ -255,7 +255,7 @@ ci = 0.95, alternative = "greater", verbose = TRUE, ...) { - params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed") + params <- parameters::model_parameters(model, verbose = verbose, effects = "fixed", effectsize_type = NULL) anova_type <- attr(params, "anova_type") params <- split(params, factor(params$Response, levels = unique(params$Response))) # make sure row order is not changed