Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for bluechi-is-online agent with --monitor parameter #1021

Closed
Tracked by #977
mwperina opened this issue Jan 7, 2025 · 2 comments · Fixed by #1025
Closed
Tracked by #977

Add integration tests for bluechi-is-online agent with --monitor parameter #1021

mwperina opened this issue Jan 7, 2025 · 2 comments · Fixed by #1025
Assignees
@nsimsolo
Labels
enhancement New feature or request jira Issues that are synced to Jira testing This issue adds or improves the testing
Milestone
v0.10

Comments

@mwperina
Copy link
Member

mwperina commented Jan 7, 2025

Please describe what you would like to see

In #962 the new package bluechi-is-online was introduced. However, adding integration tests was postponed.

A basic integration test for bluechi-is-online agent --monitor would verify that:

  • It exits immediately with non-zero result when the bluechi-agent is not connected
  • It continues monitoring the agent when the agent is connected, but it exits with non-zero status immediately after agent is disconnected


Tech hints
@mwperina mwperina added enhancement New feature or request testing This issue adds or improves the testing labels Jan 7, 2025
@mwperina mwperina added this to the v0.10 milestone Jan 7, 2025
@mwperina mwperina mentioned this issue Jan 7, 2025
Open
17 tasks
@nsimsolo
Copy link
Contributor

nsimsolo commented Jan 7, 2025

Please assign this ticket to me

@mwperina mwperina added the jira Issues that are synced to Jira label Jan 8, 2025
@mwperina mwperina mentioned this issue Jan 15, 2025
Merged
@engelmi
Copy link
Member

engelmi commented Jan 15, 2025

Done in #1025. Closing.

@engelmi engelmi closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsimsolo nsimsolo

Labels
enhancement New feature or request jira Issues that are synced to Jira testing This issue adds or improves the testing
Projects
None yet
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

add integration test for bluechi-is-online agent --monitor nsimsolo/bluechi
3 participants
@mwperina @nsimsolo @engelmi