Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackson to 2.8.5+ #22266

Closed
tlrx opened this issue Dec 19, 2016 · 0 comments · Fixed by #22596
Closed

Update Jackson to 2.8.5+ #22266

tlrx opened this issue Dec 19, 2016 · 0 comments · Fixed by #22596
Labels

Comments

@tlrx
Copy link
Member

tlrx commented Dec 19, 2016

Jackson's YAML readers (and writers) have concurrency issues when two instances try to parse (or generate) some content. They basically share a same thread local buffer, and that can make the result completely wrong.

The parsing issue has been fixed in 2.8.5 (see this commit because it is not mentioned in release notes) but our tests still fail with a writing issue.

I created FasterXML/jackson-dataformat-yaml#80 to address the Jackson's issue and this issue to track the update. Once fixed in Jackson we will have to update the dependency on 2.8.6 presumably.

@tlrx tlrx added :Core/Infra/Core Core issues without another label >upgrade v5.2.0 v6.0.0-alpha1 labels Dec 19, 2016
tlrx added a commit to tlrx/elasticsearch that referenced this issue Jan 12, 2017
@tlrx tlrx added review and removed review labels Jan 12, 2017
tlrx added a commit that referenced this issue Jan 13, 2017
tlrx added a commit that referenced this issue Jan 13, 2017
tlrx added a commit that referenced this issue Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant