From 432647eaa26cf3a1d022f616f5bbd98dc0274db0 Mon Sep 17 00:00:00 2001 From: Christian Eltzschig Date: Tue, 31 Oct 2023 08:23:28 +0100 Subject: [PATCH] [#3] Address review findings Signed-off-by: Christian Eltzschig --- .github/ISSUE_TEMPLATE/bug_report.md | 9 +++++++-- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- README.md | 10 ++++++++-- doc/release-notes/elkodon-unreleased.md | 4 ++-- 4 files changed, 19 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 73b92db..d65387a 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -10,13 +10,18 @@ assignees: '' ## Required information **Operating system:** -Output of: `uname -a` + * OS name, version + * Additionally, on Linux, Mac Os, Unix, output of: `uname -a` + * Additionally, on Windows, output of: `ver` **Rust version:** Output of: `rustc --version` +**Cargo version:** +Output of: `cargo --version` + **elkodon version:** -E.g. `v1.2.3` or `master` branch +E.g. `v1.2.3` or `main` branch **Observed result or behaviour:** A minimalistic running code example that reproduces the bug or diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index eab865b..6dbfef4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ 1. [ ] Every source code file has the SPDX header `SPDX-License-Identifier: $(LICENSE_CODE)` 1. [ ] Branch follows the naming format (`elk-123-introduce-posix-ipc-example`) 1. [ ] Commits messages are according to this [guideline][commit-guidelines] - - [ ] Commit messages have the issue ID (`[#123] add posix ipc example`) + - [ ] Commit messages have the issue ID (`[#123] Add posix ipc example`) - [ ] Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) 1. [ ] Tests follow the [best practice for testing][testing] 1. [ ] Changelog updated [in the unreleased section][changelog] including API breaking changes @@ -34,4 +34,4 @@ ## References -- Closes **TBD** + diff --git a/README.md b/README.md index 14ad746..253ce52 100644 --- a/README.md +++ b/README.md @@ -27,8 +27,14 @@ - - + +
Mathias Kraus
Mathias Kraus
Christian Eltzschig
Christian Eltzschig
+ + Mathias Kraus
+ Mathias »elBoberido« Kraus
+ + Christian Eltzschig
+ Christian »elfenpiff« Eltzschig
diff --git a/doc/release-notes/elkodon-unreleased.md b/doc/release-notes/elkodon-unreleased.md index a2203de..dd2a84d 100644 --- a/doc/release-notes/elkodon-unreleased.md +++ b/doc/release-notes/elkodon-unreleased.md @@ -30,8 +30,8 @@ ```rust // old - let fuu = Hello().IsItMeYouAreLookingFor() + let fuu = hello().is_it_me_you_re_looking_for() // new - let fuu = Hello().MyNameIsBlobb() + let fuu = hypnotoad().all_glory_to_the_hypnotoad() ```