Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete card button #841

Closed
nesadrian opened this issue Dec 4, 2024 · 11 comments · Fixed by #856
Closed

Delete card button #841

nesadrian opened this issue Dec 4, 2024 · 11 comments · Fixed by #856
Assignees
Labels
feat New feature or request front-end Frontend code, functionality, or client-side interactions needs design Requires design input

Comments

@nesadrian
Copy link
Contributor

In #825 we are redesigning the sidebar to only include PQIRs. Because of this it doesn't make much sense to keep the button for deleting a card in the sidebar. We will need a new design for this, and the issue has to be fixed before we release Flyt 2.9.

When designing, it is important to take into consideration that the linked process cards do not have an editable tooltip.

@nesadrian nesadrian added feat New feature or request needs design Requires design input front-end Frontend code, functionality, or client-side interactions labels Dec 4, 2024
@jsundarn
Copy link

jsundarn commented Dec 12, 2024

Status Update: For this issue, we analyzed and ideated a few ideas, finalized the approach, and it is now ready to move to the development stage.

@QiJin-Bouvet
Copy link

@jsundarn Please share the link of your design in Figma in this issue.

@jsundarn
Copy link

@QiJin-Bouvet I have attached the figma file here, please let me know if you have any doubts.

https://www.figma.com/design/IkHwmIQrsT0iR34f5R5UnZ/Flyt--%3E-Design?node-id=4733-177321&t=jtF9NY7zmkli0Qby-1

@srvEq srvEq self-assigned this Dec 17, 2024
@srvEq srvEq linked a pull request Dec 19, 2024 that will close this issue
5 tasks
@srvEq
Copy link
Contributor

srvEq commented Dec 19, 2024

Raised PR

@srvEq
Copy link
Contributor

srvEq commented Jan 3, 2025

@SIVN1 @ThomasBracho1987 @luan-droid Ready to test the changes in Test Env.

CC: @AnjaliPandit20 @rvaidya3007 @SIJAIEQUINOR

@SIVN1
Copy link

SIVN1 commented Jan 3, 2025

@srvEq Verified in Test env. Delete functionality for all the cards are working fine,

Our suggestion for Delete icon tool tip - Could you please add respective card name for each delete card tool tip

Example : For Main activity card delete icon tool tip - "Main activity delete node" instead of "Delete Node".

Kindly check with @jsundarn for name convention of each delete card tool tip

CC: @AnjaliPandit20 @rvaidya3007 @gopireddy-Equinor @ThomasBracho1987 @luan-droid @SIJAIEQUINOR

@srvEq
Copy link
Contributor

srvEq commented Jan 9, 2025

I have implemented the suggestions deployed in test env. Ready to test.
@luan-droid @ThomasBracho1987 @SIVN1

@luan-droid
Copy link

@srvEq Verified in Test env. Delete functionality for all the cards are working.

CC: @ThomasBracho1987 @SIVN1

@srvEq srvEq closed this as completed in #856 Jan 9, 2025
@srvEq
Copy link
Contributor

srvEq commented Jan 9, 2025

Ready to test changes in QA.
@luan-droid @ThomasBracho1987 @SIVN1

@luan-droid
Copy link

luan-droid commented Jan 9, 2025

Verified
Expected Result Delete card button is showing and is deleting the card(s)
Actual Result Delete card button is showing and is deleting the card(s)
Device Windows 64
Application Flyt
Version 2.8.0
Environment QA
Browser Google Chrome Version 131.0.6778.205 (Official Build) (64-bit) & in inkognito
Tags @srvEq, CC; @ThomasBracho1987 @SIVN1 @rvaidya3007 @SIJAIEQUINOR @AnjaliPandit20

@srvEq
Copy link
Contributor

srvEq commented Jan 10, 2025

Created a subtask to change the confirmation Message.
Changes will be tracked in 870.
CC: @AnjaliPandit20 @rvaidya3007 @SIJAIEQUINOR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request front-end Frontend code, functionality, or client-side interactions needs design Requires design input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants