Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize and improve CodeGeneratorImpl #24

Open
coderabbitai bot opened this issue Jan 19, 2025 · 0 comments
Open

Optimize and improve CodeGeneratorImpl #24

coderabbitai bot opened this issue Jan 19, 2025 · 0 comments

Comments

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2025

Multiple improvements needed in CodeGeneratorImpl:

  1. Move class name computation to a common place
  2. Optimize map handling in generated code
  3. Simplify key and value blocks in map handling
  4. Add proper logging for unknown fields

File: pibify-maven-plugin/src/main/java/com/flipkart/pibify/codegen/CodeGeneratorImpl.java

Related PR: #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant