Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway leaks internal notes to user #170

Open
landryb opened this issue Jan 21, 2025 · 4 comments · May be fixed by #171
Open

gateway leaks internal notes to user #170

landryb opened this issue Jan 21, 2025 · 4 comments · May be fixed by #171

Comments

@landryb
Copy link
Member

landryb commented Jan 21, 2025

the gateway is affected by georchestra/georchestra#4280, which might leak sensitive info.

i fixed the S-P with georchestra/georchestra#4377 because finding the fix in the code was easy, i wont be able to do the same for the gateway...
@pmauduit
Copy link
Member

somehow relates to #110

pmauduit added a commit that referenced this issue Jan 21, 2025
@pmauduit
avoid providing internal notes to /whoami endpoint (fixes #170)
6823a48
@f-necas f-necas closed this as completed Jan 21, 2025
@pmauduit pmauduit reopened this Jan 21, 2025
@pmauduit
Copy link
Member

unfinished yet, my PR is still in draft :) (the added test is failing)

@f-necas
Copy link
Collaborator

f-necas commented Jan 21, 2025 •
edited
Loading

Ah my bad ! I saw only the first one

pmauduit added a commit that referenced this issue Jan 21, 2025
@pmauduit
avoid providing internal notes to /whoami endpoint (fixes #170)
da242bf
@pmauduit
Copy link
Member

(the added test is failing)

not the added one, but the current had a side effect making other tests failing.

@pmauduit pmauduit linked a pull request Jan 21, 2025 that will close this issue
Open
@pmauduit pmauduit linked a pull request Jan 21, 2025 that will close this issue
avoid providing internal notes to /whoami endpoint (fixes #170) #171
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid providing internal notes to /whoami endpoint (fixes #170) georchestra/georchestra-gateway
3 participants
@pmauduit @landryb @f-necas