New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why ElementByJS ignores sleeper? #1169

Open

dgreshnikov opened this issue Jan 21, 2025 · 0 comments

Labels

question

dgreshnikov commented Jan 21, 2025

Rod Version: v0.116.2

func (el *Element) ElementByJS(opts *EvalOptions) (*Element, error) {
	e, err := el.page.Context(el.ctx).Sleeper(NotFoundSleeper).ElementByJS(opts.This(el.Object))
	if err != nil {
		return nil, err
	}
	return e.Sleeper(el.sleeper), nil
}

Is there a reason for that? Why don't we use .Sleeper(el.sleeper)? This leads to unexpected behavior

dgreshnikov added the question label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment