Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finalizers to all resources #1678

Open
theSuess opened this issue Sep 17, 2024 · 3 comments
Open

Add finalizers to all resources #1678

theSuess opened this issue Sep 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@theSuess
Copy link
Member

We have multiple issues like #1677 and #1626 which are caused by having dashboards/folders be deleted based on information from the Grafana CR status.

A clean solution to these kinds of issues is to implement finalizes for all resources. This way, deletion is properly locked, and we avoid race conditions when updating the Grafana instance status.
@theSuess theSuess added the enhancement New feature or request label Sep 17, 2024
@theSuess theSuess mentioned this issue Sep 17, 2024
Closed
@github-actions GitHub Actions
Copy link

This issue hasn't been updated for a while, marking as stale, please respond within the next 7 days to remove this label

@github-actions github-actions bot added the stale label Oct 18, 2024
@theSuess theSuess removed the stale label Oct 18, 2024
@Baarsgaard Baarsgaard mentioned this issue Nov 10, 2024
Closed
@github-actions GitHub Actions
Copy link

This issue hasn't been updated for a while, marking as stale, please respond within the next 7 days to remove this label

@github-actions github-actions bot added the stale label Nov 18, 2024
@theSuess theSuess removed the stale label Nov 18, 2024
@github-actions GitHub Actions
Copy link

This issue hasn't been updated for a while, marking as stale, please respond within the next 7 days to remove this label

@github-actions github-actions bot added the stale label Dec 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
@theSuess theSuess reopened this Jan 7, 2025
@github-actions github-actions bot removed the stale label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theSuess